Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.15.z] Fix getting exit code on capsule tunnel error #14823

Merged
merged 1 commit into from
Apr 17, 2024
Merged

[6.15.z] Fix getting exit code on capsule tunnel error #14823

merged 1 commit into from
Apr 17, 2024

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #14821

Problem Statement

There is a problem with capsule tunnel error handling. It throws TypeError: 'int' object is not subscriptable. By checking ssh2.channel.Channel.get_exit_status documentation it is obvious that channel.get_exit_status()[1] could never work since it was added.

Solution

Replace channel.get_exit_status() by channel.get_exit_signal() which is way more verbose providing not only return code but also error message and exit signal.

Related Issues

@Satellite-QE Satellite-QE requested a review from a team as a code owner April 17, 2024 19:06
@Satellite-QE Satellite-QE added 6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Apr 17, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_capsule.py::test_positive_update_url

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Apr 17, 2024
@Satellite-QE Satellite-QE merged commit db84209 into 6.15.z Apr 17, 2024
15 of 16 checks passed
@Satellite-QE Satellite-QE deleted the cherry-pick-6.15.z-625017b1fd6300898d8f94ad421912098aa500a7 branch April 17, 2024 19:17
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 6584
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_capsule.py::test_positive_update_url --external-logging
Test Result : ================== 1 passed, 9 warnings in 728.95s (0:12:08) ===================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lpramuk lpramuk

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Satellite-QE @lpramuk